[PATCH weston] build: Require newer version of libdrm

Eugen Friedrich friedrix at gmail.com
Mon Aug 24 04:06:45 PDT 2015


Hello dear community,

in our current project we are trying to follow the weston master branch as
much as possible,
recently introduced dependency to libdrm 2.4.59 will prevent us to use
weston 1.9,
The patches for naming correction are good and important.
so we would love to see a missing defines in the corresponding #ifdef
statement.

Are display name defines the only reason to add a dependency to 2.4.59?

2015-08-24 10:52 GMT+02:00 Pekka Paalanen <ppaalanen at gmail.com>:

> On Fri, 21 Aug 2015 23:24:54 -0700
> Bryce Harrington <bryce at osg.samsung.com> wrote:
>
> > On Fri, Aug 21, 2015 at 11:06:02PM -0500, Derek Foreman wrote:
> > > commit 89c49b3060a115e846ba1e7fbef94d14894244f2 changed the way we name
> > > outputs, but it also added the new output names VIRTUAL and DSI.
> > >
> > > These aren't available until libdrm 2.4.59
>
> Hi,
>
> sorry I forgot to check when those appeared.
>
> > Ubuntu 14.04 appears to have 2.4.60.  Presumably other distros of that
> > vintige will have similar.  So this looks like a reasonable dependency
> > bump to me.
> >
> > > Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> >
> > Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
>
> Alright. It would be very easy to just #ifdef these in case we wanted
> to keep the libdrm requirement the same. I pushed your patch, and we
> can fix it the other way if someone complains. (It's a 3 year bump, so
> I'm not surprised if I need to fix it the other way.)
>    decc965..faee330  master -> master
>
>
> Thanks,
> pq
>
> > > ---
> > >  configure.ac | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/configure.ac b/configure.ac
> > > index 425f071..d70777d 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -171,7 +171,7 @@ AC_ARG_ENABLE(drm-compositor, [
> --enable-drm-compositor],,
> > >  AM_CONDITIONAL(ENABLE_DRM_COMPOSITOR, test x$enable_drm_compositor =
> xyes)
> > >  if test x$enable_drm_compositor = xyes; then
> > >    AC_DEFINE([BUILD_DRM_COMPOSITOR], [1], [Build the DRM compositor])
> > > -  PKG_CHECK_MODULES(DRM_COMPOSITOR, [libudev >= 136 libdrm >= 2.4.30
> gbm mtdev >= 1.1.0])
> > > +  PKG_CHECK_MODULES(DRM_COMPOSITOR, [libudev >= 136 libdrm >= 2.4.59
> gbm mtdev >= 1.1.0])
> > >    PKG_CHECK_MODULES(DRM_COMPOSITOR_GBM, [gbm >= 10.2],
> > >                 [AC_DEFINE([HAVE_GBM_FD_IMPORT], 1, [gbm supports
> dmabuf import])],
> > >                 [AC_MSG_WARN([gbm does not support dmabuf import, will
> omit that capability])])
> > > --
> > > 2.4.6
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150824/6bdf9f7a/attachment.html>


More information about the wayland-devel mailing list