[PATCH] ivi-shell: SEGV occurs when multi touch happens in transition

Bryce Harrington bryce at osg.samsung.com
Fri Feb 6 16:22:42 PST 2015


On Fri, Feb 06, 2015 at 08:34:32AM +0000, Daniel Stone wrote:
> On Friday, February 6, 2015, Nobuhiko Tanibata <
> NOBUHIKO_TANIBATA at xddp.denso.co.jp> wrote:
> 
> > of application launching. This is because cancel callback is mistakenly
> > set to weston_touch_grab_interface. To fix this issue, add a
> > callback, touch_move_workspace_grab_frame and set it to the
> > weston_touch_grab_interface like desktop-shell.
> >
> > Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA at xddp.denso.co.jp
> > <javascript:;>>

Yes, you're right, the weston_touch_grab_interface has five function
pointers, for:  down, up, motion, frame, cancel.  The frame one was
missing.

(Hmm, seems like something ought to be checking for if a structure is
being initialized with fewer elements than it has members.  Maybe lint
or coverity would catch that.)

> 
>  Reviewed-by: Daniel Stone <daniels at collabora.com>

Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

Thanks, applied:

   7b9efcb..82cc25b  master -> master


> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel



More information about the wayland-devel mailing list