[PATCH weston v2 7/7] pixman-renderer: implement surface_copy_content

Daniel Stone daniel at fooishbar.org
Wed Feb 25 03:58:43 PST 2015


On 25 February 2015 at 11:11, Pekka Paalanen
<pekka.paalanen at collabora.co.uk> wrote:
> this series is also available at:
> http://cgit.collabora.com/git/user/pq/weston.git/log/?h=surface-shot-2
> The main change since v1 is removing the stride and pixel format
> arguments from the copy_content API. These are now documented instead.
> Honouring arbitrary stride would have been inconvenient in gl-renderer,
> and only one pixel format was supported anyway.

For the series:
Reviewed-by: Daniel Stone <daniels at collabora.com>

The gs->pitch bit in 6/7 is pretty iffy, in terms of gl-renderer never
storing the actual usable width of the buffer, and uploading the whole
thing with stride. So if you upload a padded SHM buffer and then read
back from it, you'll be pulling the stride in as well. But it's not a
regression, just something to fix up later.


More information about the wayland-devel mailing list