[PATCH weston v2 7/7] pixman-renderer: implement surface_copy_content
pekka.paalanen at collabora.co.uk
Wed Feb 25 05:01:07 PST 2015
On Wed, 25 Feb 2015 11:58:43 +0000
Daniel Stone <daniel at fooishbar.org> wrote:
> On 25 February 2015 at 11:11, Pekka Paalanen
> <pekka.paalanen at collabora.co.uk> wrote:
> > this series is also available at:
> > http://cgit.collabora.com/git/user/pq/weston.git/log/?h=surface-shot-2
> > The main change since v1 is removing the stride and pixel format
> > arguments from the copy_content API. These are now documented instead.
> > Honouring arbitrary stride would have been inconvenient in gl-renderer,
> > and only one pixel format was supported anyway.
> For the series:
> Reviewed-by: Daniel Stone <daniels at collabora.com>
> The gs->pitch bit in 6/7 is pretty iffy, in terms of gl-renderer never
> storing the actual usable width of the buffer, and uploading the whole
> thing with stride. So if you upload a padded SHM buffer and then read
> back from it, you'll be pulling the stride in as well. But it's not a
> regression, just something to fix up later.
Yes, this is indeed the problem with gl-renderer and I tried to
communicate that in the commit message. Pixman-renderer does not suffer
from it, though, so that's a difference in their behaviour.
I actually tested with wl_shm buffers that have twice the stride and
confirmed that behaviour, using weston-terminal and weston-scaler (uses
wl_viewport to crop the buffer), on both pixman and gl-renderers.
All pushed now.
f6a6592..6764bbe master -> master
More information about the wayland-devel