[PATCH v2 weston 00/16] Atomic modesetting support

Bryce Harrington bryce at osg.samsung.com
Fri Jul 10 18:05:48 PDT 2015


On Fri, Jun 26, 2015 at 02:16:55PM -0500, Derek Foreman wrote:
> On 22/06/15 11:25 AM, Daniel Stone wrote:
> > Hi,
> > Thanks to everyone who reviewed the previous series. This new series
> > cleans up the previous patches, introduces a few fixes (e.g. not relying
> > on a repaint to pull us out of DPMS), and crucially adds support for the
> > libdrm TEST_ONLY interface (allowing us to check before we commit, e.g.
> > that a particular plane combination is workable), using the new cursor
> > API from libdrm.
> 
> Everything up to and including 8/16 seems like beneficial clean-up or
> bug fix that could land independently of later bits?
> 
> For that half,
> Reviewed-By: Derek Foreman <derekf at osg.samsung.com>
> 
> (The rest I haven't had a chance to look at yet)

At least for patches 1-6 I tend to agree; they're good cleanup or
refactoring, and no reason not to just get them landed.  Patch 7 started
to look a bit more ambitious to me so I stopped there.  But with 1-6,
might save time having to rebase them.  Unfortunately they already don't
apply, but if you can split them out from the remainder of the patchset,
I'd be +1 for just landing them immediately.

Bryce

> > This still relies on support not yet mainlined. Currently I am using:
> > git://git.collabora.co.uk/git/user/daniels/linux.git#wip/4.2.x/atomic-i915
> > git://git.collabora.co.uk/git/user/daniels/libdrm.git#atomic
> > 
> > Cheers,
> > Daniel
> > 
> > _______________________________________________
> > wayland-devel mailing list
> > wayland-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> > 
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list