[PATCH v2 weston 04/16] compositor-drm: Record current DPMS level

[Daniel Stone]

Hi,

On 11 July 2015 at 01:58, Bryce Harrington <bryce at osg.samsung.com> wrote:
> On Mon, Jun 22, 2015 at 05:25:09PM +0100, Daniel Stone wrote:
>> +     ret = drmModeConnectorSetProperty(c->drm.fd, output->connector_id,
>> +                                       output->dpms_prop->prop_id, level);
>> +     if (ret) {
>
> Just a nitpick, but we don't actually use ret for anything other than
> this test.  Maybe save the variable and just do "if
> (drmModeConnectorSetProperty(..." ?

I'd actually prefer not to, just for readability/consistency's sake.
Thanks though. :)

Cheers,
Daniel