[PATCH weston v6 3/4] Converted the config parser test to the new framework.

[Jon A. Cruz]

On 07/07/2015 05:08 AM, Pekka Paalanen wrote:
> On Thu,  2 Jul 2015 23:36:46 -0700
> "Jon A. Cruz" <jonc at osg.samsung.com> wrote:
> 
>> Signed-off-by: Jon A. Cruz <jonc at osg.samsung.com>
>> ---
>>  Makefile.am                |  10 +-
>>  tests/config-parser-test.c | 371 +++++++++++++++++++++++++++++++++++++--------
>>  2 files changed, 320 insertions(+), 61 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index 89d9e4c..42f0ed4 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -1106,7 +1106,15 @@ libtest_runner_la_SOURCES =			\
>>  libtest_runner_la_CFLAGS = $(AM_CFLAGS) $(COMPOSITOR_CFLAGS)
>>  
>>  config_parser_test_SOURCES = tests/config-parser-test.c
>> -config_parser_test_LDADD = libshared.la libtest-runner.la $(COMPOSITOR_LIBS)
>> +config_parser_test_LDADD =	\
>> +	libshared.la		\
>> +	$(COMPOSITOR_LIBS)	\
>> +	libzunitc.la		\
>> +	libzunitcmain.la
>> +config_parser_test_CFLAGS =			\
>> +	$(AM_CFLAGS)				\
>> +	-Wunused \
>> +	-I$(top_srcdir)/tools/zunitc/inc
> 
> Hi,
> 
> what's with the -Wunused?
> We should already have -Wall -Wextra from GCC_FLAGS.

Removed.

Quite odd. I had to add it at one point to get expected warnings to
appear. However that must have just been an odd case with flags not
quite correct in autoconf runs.

>>  
>>  vertex_clip_test_SOURCES =			\
>>  	tests/vertex-clip-test.c		\
>> diff --git a/tests/config-parser-test.c b/tests/config-parser-test.c
>> index f659004..1d4e96a 100644
>> --- a/tests/config-parser-test.c
>> +++ b/tests/config-parser-test.c
> 
>> +/** @todo individual t1 tests should have more descriptive names. */
>> +
>> +ZUC_TEST_F(config_test_t1, test001)
> 
> Still todo? :-)
> 

Sadly I did not write the original tests so am not quite sure of
appropriate domain-specific names. :-(


> The rest here I browsed quickly, but seems good to me.
> 
> 
> Thanks,
> pq
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> 

-- 
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
jonc at osg.samsung.com