[PATCH libinput v3 0/5] touchpad gestures support

[Hans de Goede]

Hi,

On 01-05-15 20:54, Carlos Garnacho wrote:
> Hey Hans :),
>
> On Wed, Apr 29, 2015 at 2:18 PM, Hans de Goede <hdegoede at redhat.com> wrote:
>> Hi All,
>>
>> Here is v3 of my touchpad gestures support patch series.
>>
>> Changes since v2:
>> - For pinch gestures instead of reporting finger distance deltas report a scale
>>    value which is relative to the initial finger distance
>> - Added a new patch to provide cancellation information when a gesture ends
>
> Thanks much for this, these solve all the API issues I was facing.
>  From trying things out, it all works as expected. I'll keep
> experimenting with this v3 anyway.

Good, I'm glad to hear that the API is now to your liking.

>> Changes since v1:
>> - Merge the gesture capability flag and event-debug patched into
>>    the "touchpad: Add an API for touchpad gesture events"
>> - Update the swipe and pinch/rotate implementations to work with the new
>>    typesafe device and normalized coordinates (rebased on latest master),
>>    this results in a nice cleanup
>>
>> I've not yet added filtering / smoothing of the pinch distance (now scale)
>> events, because it is not entirely clear to me if everyone thinks this is a
>> good idea. So please let me know if you want me to implement this and then
>> I'll do a follow up patch with it.
>
> The problem I was seeing with distance jumps on close 2-fg pinches
> isn't as big as I first expected (drifts are around/sub 0.01 in
> scale), so I guess it's not such an urgent item.

Ok, since implementing this is not for free (it will add code and a bit
of initial latency + lag to events), I'm not going to do this for now then,
if you ever feel it is needed drop me a mail and I'll add it.

Regards,

Hans