[PATCH weston 07/10] tests: Add screenshot recording capability to weston-test

[Pekka Paalanen]

On Sun, 10 May 2015 20:17:55 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:

> On Sat, May 09, 2015 at 02:56:54PM +0100, Daniel Stone wrote:
> > Hi,
> > 
> > On 7 May 2015 at 01:44, Bryce Harrington <bryce at osg.samsung.com> wrote:
> > > +static void
> > > +copy_bgra_yflip(uint8_t *dst, uint8_t *src, int height, int stride)
> > > +
> > > +static void
> > > +copy_bgra(uint8_t *dst, uint8_t *src, int height, int stride)
> > > +
> > > +static void
> > > +copy_row_swap_RB(void *vdst, void *vsrc, int bytes)
> > > +
> > > +static void
> > > +copy_rgba_yflip(uint8_t *dst, uint8_t *src, int height, int stride)
> > > +
> > > +static void
> > > +copy_rgba(uint8_t *dst, uint8_t *src, int height, int stride)
> > 
> > Can we please use Pixman for these instead of open-coding them?

I think those are my bad originally.

> I don't understand, explain?  These routines already existing in the
> screenshooter client, I just moved them to shared so I could reuse them.

It's not a blocker to me, but letting Pixman do this work would indeed
be much better. I would not go the trouble of properly sharing this
code, but rather have Pixman do it with pixman_image_composite32().

I think Pixman is able to do the y-flip if you use negative stride and
proper pointer adjustments... if not, one can always use a transform.


Thanks,
pq