[PATCH weston 07/10] tests: Add screenshot recording capability to weston-test

[Daniel Stone]

Hi,

On Monday, May 11, 2015, Bryce Harrington <bryce at osg.samsung.com> wrote:

> On Sat, May 09, 2015 at 02:56:54PM +0100, Daniel Stone wrote:
> > On 7 May 2015 at 01:44, Bryce Harrington <bryce at osg.samsung.com
> <javascript:;>> wrote:
> > > +static void
> > > +copy_bgra_yflip(uint8_t *dst, uint8_t *src, int height, int stride)
> > > +
> > > +static void
> > > +copy_bgra(uint8_t *dst, uint8_t *src, int height, int stride)
> > > +
> > > +static void
> > > +copy_row_swap_RB(void *vdst, void *vsrc, int bytes)
> > > +
> > > +static void
> > > +copy_rgba_yflip(uint8_t *dst, uint8_t *src, int height, int stride)
> > > +
> > > +static void
> > > +copy_rgba(uint8_t *dst, uint8_t *src, int height, int stride)
> >
> > Can we please use Pixman for these instead of open-coding them?
>
> I don't understand, explain?  These routines already existing in the
> screenshooter client, I just moved them to shared so I could reuse them.


Ugh, I'd missed that. Fair enough then, but could you please add a /* XXX:
It would be nice if we used Pixman to do all this rather than our own
implementation */?

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150513/1204f7b9/attachment.html>