[PATCH] test/ivi: include protocol headers for all used protocols

Pekka Paalanen ppaalanen at gmail.com
Fri May 22 00:40:20 PDT 2015


On Thu, 21 May 2015 19:20:57 -0700
Bill Spitzak <spitzak at gmail.com> wrote:

> This seems like a good idea for consistency as the client and server
> protocol should not be treated differently than others. This means the
> code will compile even if the protocol headers are generated with the
> core only (-c) switch.

They will never be generated with -c.

> ---
>  clients/ivi-shell-user-interface.c |    1 +
>  tests/weston-test-client-helper.h  |    1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/clients/ivi-shell-user-interface.c b/clients/ivi-shell-user-interface.c
> index a83f9ad..031e9a9 100644
> --- a/clients/ivi-shell-user-interface.c
> +++ b/clients/ivi-shell-user-interface.c
> @@ -37,6 +37,7 @@
>  #include "../shared/os-compatibility.h"
>  #include "ivi-application-client-protocol.h"
>  #include "ivi-hmi-controller-client-protocol.h"
> +#include "wayland-client-protocol.h"
>  
>  /**
>   * A reference implementation how to use ivi-hmi-controller interface to
> diff --git a/tests/weston-test-client-helper.h b/tests/weston-test-client-helper.h
> index 8635471..5284b68 100644
> --- a/tests/weston-test-client-helper.h
> +++ b/tests/weston-test-client-helper.h
> @@ -29,6 +29,7 @@
>  #include <stdbool.h>
>  #include "weston-test-runner.h"
>  #include "weston-test-client-protocol.h"
> +#include "wayland-client-protocol.h"
>  
>  struct client {
>  	struct wl_display *wl_display;

Are you sure "" is appropriate and not <> for the #includes? These
headers are not generated by Weston, but are found installed in the
system.


Thanks,
pq


More information about the wayland-devel mailing list