[PATCH] test/ivi: include protocol headers for all used protocols

Bill Spitzak spitzak at gmail.com
Fri May 22 11:42:43 PDT 2015



On 05/22/2015 12:40 AM, Pekka Paalanen wrote:
> On Thu, 21 May 2015 19:20:57 -0700
> Bill Spitzak <spitzak at gmail.com> wrote:
>
>> This seems like a good idea for consistency as the client and server
>> protocol should not be treated differently than others. This means the
>> code will compile even if the protocol headers are generated with the
>> core only (-c) switch.
>
> They will never be generated with -c.

Yes but testing that was how I located this.

>>   #include <stdbool.h>
>>   #include "weston-test-runner.h"
>>   #include "weston-test-client-protocol.h"
>> +#include "wayland-client-protocol.h"
>
> Are you sure "" is appropriate and not <> for the #includes? These
> headers are not generated by Weston, but are found installed in the
> system.

I believe you are right. <wayland-client.h> is always included with <> 
in weston, so this should be done the same way. I was confused by the 
local protocol header files. New patch momentarily...




More information about the wayland-devel mailing list