[PATCH weston 01/10] Use fullscreen-shell.xml from wayland-protocols

[Bill Spitzak]

On Thu, Nov 5, 2015 at 11:46 AM, Bryce Harrington <bryce at osg.samsung.com>
wrote:

>
> Hmm.  With l's and 1's looking so similar in certain fonts, "shell1" is
> going to look like a typo to some users.  IMO it would be better to
> distinguish this version number with at least an underscore.
> "_shell_v1_" would feel more consistent with the scheme being used in
> the header file name, protocol file name, macro definitions, etc.
>

I'm not very clear on why the '1' is necessary at all, but it seems to me
like it should be next to the 'z', rather than adding the odd stuff at both
ends. Also I notice the header filename is following a completely different
pattern of using "x-unstable-v1" rather than the "zx1" being used for the
symbols.

Can the plan be changed to make the protocols have names more like the
header file, ie  wl_fullscreen_shell_unstable_v1 in this case? I think that
might be more readable and it would be nice if names matched. Using _
instead of - in the header filenames might be nice, too.

Pardon me for kind of glazing over all that discussion about protocol
versions, but I am not really seeing the reason for unstable protocols to
use different names than the final stable one. If it is unstable then the
meaning of a given symbol may change. This includes changing to the stable
one. Seems like the proposed final name could be used.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20151105/81d98202/attachment.html>