[RFC wayland] protocol: Add wl_surface.buffer_damage

[Daniel Stone]

Hi,

On 7 November 2015 at 16:59, Jasper St. Pierre <jstpierre at mecheye.net> wrote:
> I don't see where. I see eglSwapBuffersWithDamage still looking like
> it shoves the rects across the wire in buffer space, without any
> modification.
>
> http://cgit.freedesktop.org/mesa/mesa/tree/src/egl/drivers/dri2/platform_wayland.c#n705

A bug which should be fixed ...

> I checked the Mali driver implementation I have, and it does something similar.

Mali 6xx doesn't do that.

Cheers,
Daniel

> On Sat, Nov 7, 2015 at 2:32 AM, Daniel Stone <daniel at fooishbar.org> wrote:
>> On 6 November 2015 at 19:08, Jasper St. Pierre <jstpierre at mecheye.net> wrote:
>>> To help clear things up, I think we should deprecate the
>>> wl_surface.damage request and document that the coordinates are
>>> effectively undefined -- for legacy reasons, if you see
>>> wl_surface.damage, it should be considered a damage for the entire
>>> surface.
>>
>> Why? Mesa fixed that bug two years ago, I don't know of a non-Mesa EGL
>> implementation with that bug, and non-EGL clients are perfectly
>> capable of implementing it correctly themselves. Whilst introducing
>> buffer_damage, we could obliterate surface damage out of spite, but
>> that seems like a giant middle finger to everyone who wrote conformant
>> and performant apps, and now gets their entire buffer smashed through
>> TexImage2D every time they want to blink a cursor.
>>
>> Cheers,
>> Daniel
>
>
>
> --
>   Jasper