[PATCH weston] configure: don't control egl version

[Pekka Paalanen]

On Wed, 18 Nov 2015 10:23:50 +0000
"Ucan, Emre (ADITG/SW1)" <eucan at de.adit-jv.com> wrote:

> The required version only corresponds to version of mesa implementation.
> This mesa version requirement causes configure errors,
> when weston is configured for a different egl implementation than mesa.
> Because the version of the egl drivers are not alligned
> to the mesa version.

Yes, this is sad. When Mesa started providing a egl.pc file and others,
it encoded the Mesa version in them, not the EGL version. I've tried to
ask around about this and people mostly do not care. I think someone
even said that other implementations should just advertise Mesa version
numbers in their .pc files.

Furthermore, Mesa does not install any .pc file that would be specific
to Mesa, which means that egl.pc et al. are the only way to impose
version requirements on Mesa at build time.

We should also note, that .pc version requirements are build time
requirements, not necessarily runtime requirements. That's hard to
remember, and especially tricky with EGL and GL libs that have several
implementations.

Often binaries are built against Mesa, but then deployed with a
proprietary EGL/GL stack. This is probably a major reason why people
don't care that egl.pc encodes Mesa version. If you hacked Weston to
use some proprietary APIs, this won't work.

> Therefore, I deleted the version controlling for egl,
> so that weston can be configured for a different egl implementation.

Because of all the above, I will not object to this patch, so:
Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq

> Signed-off-by: Emre Ucan <eucan at de.adit-jv.com>
> ---
>  configure.ac |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index c6f7fc8..50daa62 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -85,8 +85,8 @@ AC_ARG_ENABLE(egl, [  --disable-egl],,
>  AM_CONDITIONAL(ENABLE_EGL, test x$enable_egl = xyes)
>  if test x$enable_egl = xyes; then
>  	AC_DEFINE([ENABLE_EGL], [1], [Build Weston with EGL support])
> -	PKG_CHECK_MODULES(EGL, [egl >= 7.10 glesv2])
> -        PKG_CHECK_MODULES([EGL_TESTS], [egl >= 7.10 glesv2 wayland-client wayland-egl])
> +	PKG_CHECK_MODULES(EGL, [egl glesv2])
> +        PKG_CHECK_MODULES([EGL_TESTS], [egl glesv2 wayland-client wayland-egl])
>  	PKG_CHECK_MODULES([GL_RENDERER], [libdrm])
>  fi
>  
> @@ -349,7 +349,7 @@ AC_ARG_ENABLE(simple-egl-clients,
>  AM_CONDITIONAL(BUILD_SIMPLE_EGL_CLIENTS, test "x$enable_simple_egl_clients" = "xyes")
>  if test x$enable_simple_egl_clients = xyes; then
>    PKG_CHECK_MODULES(SIMPLE_EGL_CLIENT,
> -                    [egl >= 7.10 glesv2 wayland-client wayland-egl wayland-cursor])
> +                    [egl glesv2 wayland-client wayland-egl wayland-cursor])
>  fi
>  
>  AC_ARG_ENABLE(simple-intel-dmabuf-client,
> @@ -377,7 +377,7 @@ if test x$enable_clients = xyes; then
>  
>    # Only check for cairo-egl if a GL or GLES renderer requested
>    AS_IF([test "x$cairo_modules" = "xcairo-gl" -o "x$cairo_modules" = "xcairo-glesv2"], [
> -    PKG_CHECK_MODULES(CAIRO_EGL, [wayland-egl egl >= 7.10 cairo-egl >= 1.11.3 $cairo_modules],
> +    PKG_CHECK_MODULES(CAIRO_EGL, [wayland-egl egl cairo-egl >= 1.11.3 $cairo_modules],
>                        [have_cairo_egl=yes], [have_cairo_egl=no])
>      AS_IF([test "x$have_cairo_egl" = "xyes"],
>  	  [AC_DEFINE([HAVE_CAIRO_EGL], [1], [Have cairo-egl])],

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20151118/e4227363/attachment.sig>