[PATCH libinput 00/14] tablet: the big "tablet" -> "tablet tool" rename

Hans de Goede hdegoede at redhat.com
Thu Nov 19 01:32:22 PST 2015


Hi,

On 18-11-15 05:17, Peter Hutterer wrote:
>
> The current tablet API is a bit inconsistent, we have various 'tablet'
> prefixes (libinput_event_tablet) and 'tool' prefixes
> (libinput_tool_get_serial). That made sense in the early stages when the
> emphasis on tools wasn't as strong as it is now.
>
> The tablet interface now is aimed solely at tablet tools and we get
> inconsistencies in the API, it's not always clear whether something is a
> libinput_tool_foo or a libinput_tablet_foo. This patchset renames everything
> tablet-related to use 'tablet_tool' as prefix. Makes the API verbose but not
> much to do about that unless someone comes up with a better name than
> "tablet tool".
>
> The wayland tablet protocol is also tool-focused, so this rename brings it
> in line.
>
> Patches are all simple sed renames with a few indentation changes, and
> split into 13 patches to avoid overloading reviewer brains :)
> Patch 14 is new, and has a bunch of documentation on top.
>
> Cheers,
>    Peter

Big series :)  Thanks for splitting it up to make reviewing easier.

I cannot find anything wrong with it:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans


More information about the wayland-devel mailing list