[PATCH][weston] animation: Fix potential leak of memory pointed to by move

Lucas Tanure tanure at linux.com
Sat Oct 3 07:18:32 PDT 2015


Free move before return if animation is null.

Signed-off-by: Lucas Tanure <tanure at linux.com>
---
 src/animation.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/animation.c b/src/animation.c
index cc7482d..2c7943f 100644
--- a/src/animation.c
+++ b/src/animation.c
@@ -471,8 +471,10 @@ weston_move_scale_run(struct weston_view *view, int dx, int dy,
 	animation = weston_view_animation_create(view, start, end, move_frame,
 						 NULL, move_done, data, move);
 
-	if (animation == NULL)
+	if (animation == NULL){
+		free(move);
 		return NULL;
+	}
 
 	weston_spring_init(&animation->spring, 400.0, 0.0, 1.0);
 	animation->spring.friction = 1150;
-- 
2.6.0



More information about the wayland-devel mailing list