[PATCH][weston] animation: Fix potential leak of memory pointed to by move

[Giulio Camuffo]

2015-10-03 17:18 GMT+03:00 Lucas Tanure <tanure at linux.com>:
> Free move before return if animation is null.
>
> Signed-off-by: Lucas Tanure <tanure at linux.com>

Reviewed-by: Giulio Camuffo <giuliocamuffo at gmail.com>

> ---
>  src/animation.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/animation.c b/src/animation.c
> index cc7482d..2c7943f 100644
> --- a/src/animation.c
> +++ b/src/animation.c
> @@ -471,8 +471,10 @@ weston_move_scale_run(struct weston_view *view, int dx, int dy,
>         animation = weston_view_animation_create(view, start, end, move_frame,
>                                                  NULL, move_done, data, move);
>
> -       if (animation == NULL)
> +       if (animation == NULL){
> +               free(move);
>                 return NULL;
> +       }
>
>         weston_spring_init(&animation->spring, 400.0, 0.0, 1.0);
>         animation->spring.friction = 1150;
> --
> 2.6.0
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel