[PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

Olivier Fourdan ofourdan at redhat.com
Tue Apr 12 15:17:34 UTC 2016


> > > Good point. Setting an invalid state should probably result in a
> > > protocol error.
> > 
> > No this cannot be a protocol error because that makes it difficult to
> > change the size range to a new one that does not intersect the old one.
> > 
> > Perhaps having the commit of an invalid state be a protocol error is ok.
> 
> We'd reach an invalid state only once it's applied, ie after the commit.
> 
> So the client can (and must) set a Min <= Max before the commit, otherwise
> it's an invalid state that will lead to a protocol error.
> 
> That's what I've tried to specify in v6:
> 
> 	Values set in this way are double-buffered. They will get applied
> 	on the next commit.
> 
> 	[...]
> 
> 	Requesting a minimum size to be larger than the maximum size of
> 	a surface is illegal and will result in a protocol error.

But that raise another point, what if the client itself specifies a geometry (using set_window_geometry) outside of the min/max?

I reckon that would be a protocol error as well. if so, I guess it means I have to update the descriptions of set_window_geometry accordingly.

Cheers,
Olivier


More information about the wayland-devel mailing list