[PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

Olivier Fourdan ofourdan at redhat.com
Tue Apr 12 16:39:26 UTC 2016


> On 04/12/2016 08:17 AM, Olivier Fourdan wrote:
> [...]
> >
> > But that raise another point, what if the client itself specifies a
> > geometry (using set_window_geometry) outside of the min/max?
> >
> > I reckon that would be a protocol error as well. if so, I guess it means I
> > have to update the descriptions of set_window_geometry accordingly.
> 
> No, that is explicitly allowed.
> 
> It allows a client to say "I look best below this size, but if the
> compositor wants to fill a larger rectangle, I can draw something nicer
> than the compositor can do (the compositor can only pad or scale)".

That's something different, isn't it? The compositor sending a configure event and the size specified there must be obeyed by the client (as specified in the spec for maximize and fullscreen state, but the point of using min/max is precisely to let the compositor know that such states are not desirable for that given surface).

If the compositor insist of maximizing a window that has set a max size smaller than the output, then yes, the client must obey.a

> An example is a calculator that may want to continue expanding the
> output text area, while restricting the size of the buttons.

Err, that's the internal layout of the app, not something xdg-shell would interfere with, or I misunderstand you?

My point was more about the client itself setting min/max and then setting a geometry that falls outside of the limits it sets itself, I reckon that should be a protocol error, the client is sending incompatible requests to the compositor.

Cheers,
Olivier


More information about the wayland-devel mailing list