[PATCH v2 libinput 0/5] Add tablet pad support

Jason Gerecke killertofu at gmail.com
Thu Apr 14 22:38:24 UTC 2016


On 04/10/2016 09:15 PM, Peter Hutterer wrote:
> 
> Second version of the tablet pad support patches. The main change is
> switching from button codes to simple button numbers. This is motivated
> by the fact that most buttons don't have any actual meaning and the only
> reason we have something other than BTN_0, BTN_1 etc is that we run out of
> space in the kernel's event code range. What a button does is defined
> largely by the client anyway.
> 
> This also caused the removal of the seat button count and a change from
> libinput_event_tablet_pad_get_button() to the more explicitly named
> libinput_event_tablet_pad_get_button_number(). Just to drive the point home.
> 
> Cheers,
>   Peter

Just a few small issues highlighted in their respective patches (esp. in
patch 4), but nothing that I think is beyond a pre-push fixup.

Reviewed-by: Jason Gerecke <jason.gerecke at wacom.com>
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....


More information about the wayland-devel mailing list