[PATCH v2 libinput 0/5] Add tablet pad support

Carlos Garnacho carlosg at gnome.org
Fri Apr 15 11:02:00 UTC 2016


Hi!,

On Mon, Apr 11, 2016 at 5:15 AM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
>
> Second version of the tablet pad support patches. The main change is
> switching from button codes to simple button numbers. This is motivated
> by the fact that most buttons don't have any actual meaning and the only
> reason we have something other than BTN_0, BTN_1 etc is that we run out of
> space in the kernel's event code range. What a button does is defined
> largely by the client anyway.
>
> This also caused the removal of the seat button count and a change from
> libinput_event_tablet_pad_get_button() to the more explicitly named
> libinput_event_tablet_pad_get_button_number(). Just to drive the point home.

The whole series look great to me, just the small glitch I pointed out
in 1/5. Other than that, the whole series is:

Reviewed-by: Carlos Garnacho <carlosg at gnome.org>

Cheers,
  Carlos


More information about the wayland-devel mailing list