[PATCH wayland] connection: remove redundant assignment

Marek Chalupa mchqwerty at gmail.com
Fri Apr 22 15:46:00 UTC 2016


the code is something like:

  if (object == NULL && ...) {
      object = NULL;
      return;
  }

first, the object is already NULL, second, the assignment has no effect
since we return from the function right away

Signed-off-by: Marek Chalupa <mchqwerty at gmail.com>
---
 src/connection.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/connection.c b/src/connection.c
index c0e322f..747229e 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -838,7 +838,6 @@ wl_closure_lookup_objects(struct wl_closure *closure, struct wl_map *objects)
 			} else if (object == NULL && id != 0) {
 				wl_log("unknown object (%u), message %s(%s)\n",
 				       id, message->name, message->signature);
-				object = NULL;
 				errno = EINVAL;
 				return -1;
 			}
-- 
2.5.5



More information about the wayland-devel mailing list