[PATCH wayland] connection: remove redundant assignment

Eric Engestrom eric.engestrom at imgtec.com
Fri Apr 22 17:14:41 UTC 2016


On Fri, Apr 22, 2016 at 05:46:00PM +0200, Marek Chalupa wrote:
> the code is something like:
> 

Maybe add:
	struct wl_object *object;
to your abridged version to clearly show that it's a local object?

>   if (object == NULL && ...) {
>       object = NULL;
>       return;
>   }
> 
> first, the object is already NULL, second, the assignment has no effect
> since we return from the function right away
> 
> Signed-off-by: Marek Chalupa <mchqwerty at gmail.com>

Either way, it's
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>


More information about the wayland-devel mailing list