[PATCH weston] Makefile.am: Fix libtool race

Emil Velikov emil.l.velikov at gmail.com
Mon Aug 15 15:51:32 UTC 2016


On 15 August 2016 at 16:29, Quentin Glidic
<sardemff7+wayland at sardemff7.net> wrote:
> From: Quentin Glidic <sardemff7+git at sardemff7.net>
>
> Signed-off-by: Quentin Glidic <sardemff7+git at sardemff7.net>
> ---
>  Makefile.am | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Makefile.am b/Makefile.am
> index 6c3f4f7..1e63a58 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -61,6 +61,14 @@ CLEANFILES = weston.ini                              \
>         internal-screenshot-00.png              \
>         $(BUILT_SOURCES)
>
> +# Libtool race fix
> +# libweston-desktop depends on libweston, and desktop-shell depends on both.
> +# This leads to a libtool race at installation, because libtool re-links
> +# everything.
> +# If you add more fixes, you may need a workaround to keep automake generated
> +# targets. See http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7328
> +install-libweston_moduleLTLIBRARIES install-moduleLTLIBRARIES: install-libLTLIBRARIES
> +
Or we can convince people into using slibtool - it doesn't relink ;-)
Written in C, a bit faster although it's missing --uninstall atm (iirc).

On the patch in question - checked with the Makefile.in and things look great.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil

[1] http://git.midipix.org/cgit.cgi/slibtool/tree/README


More information about the wayland-devel mailing list