[PATCH weston] Makefile.am: Fix libtool race

[Pekka Paalanen]

On Mon, 15 Aug 2016 16:51:32 +0100
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 15 August 2016 at 16:29, Quentin Glidic
> <sardemff7+wayland at sardemff7.net> wrote:
> > From: Quentin Glidic <sardemff7+git at sardemff7.net>
> >
> > Signed-off-by: Quentin Glidic <sardemff7+git at sardemff7.net>
> > ---
> >  Makefile.am | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index 6c3f4f7..1e63a58 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -61,6 +61,14 @@ CLEANFILES = weston.ini                              \
> >         internal-screenshot-00.png              \
> >         $(BUILT_SOURCES)
> >
> > +# Libtool race fix
> > +# libweston-desktop depends on libweston, and desktop-shell depends on both.
> > +# This leads to a libtool race at installation, because libtool re-links
> > +# everything.
> > +# If you add more fixes, you may need a workaround to keep automake generated
> > +# targets. See http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7328
> > +install-libweston_moduleLTLIBRARIES install-moduleLTLIBRARIES: install-libLTLIBRARIES
> > +  
> Or we can convince people into using slibtool - it doesn't relink ;-)
> Written in C, a bit faster although it's missing --uninstall atm (iirc).

Oh, never heard of it before. Might be interesting but a discussion for
calmer times.

> On the patch in question - checked with the Makefile.in and things look great.
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Go ahead and push.


Thanks,
pq


> 
> -Emil
> 
> [1] http://git.midipix.org/cgit.cgi/slibtool/tree/README
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160816/bb11a179/attachment.sig>