[PATCH] clients: fix build on Linux

Olivier Fourdan ofourdan at redhat.com
Fri Jan 15 00:15:47 PST 2016


Hi Derek,

----- Original Message -----
> > stropts.h is not available on Linux.
> Well, this is all fascinating. :)

Yeah, sorry, my sentence was badly worded, I should have written "streams is not available on Linux upstream" instead (even though there've been 3rd party modules in the past).

"stropts.h" is part of the glibc but, precisely because streams is missing, downstream Fedora is patching the glibc to remove the header to avoid issues with apps trying to use it, which explains why the code as it was wouldn't build on Fedora.

The rationale is coming from https://bugzilla.redhat.com/show_bug.cgi?id=436349

> I'm going to land the first simpler patch that just removes #include
> <stropts.h>  (with my Reviewed-by)
> 
> linux/videodev2.h includes linux/ioctl.h right away, so I think we're
> all good.
> 
> Thanks for catching this!

Thanks!
Olivier


More information about the wayland-devel mailing list