[PATCH weston v2] Makefile: Fix compilation error when git commit message has quotes

Pekka Paalanen ppaalanen at gmail.com
Wed Jun 15 08:44:20 UTC 2016

On Thu, 14 Apr 2016 14:53:12 +0300
Pekka Paalanen <ppaalanen at gmail.com> wrote:

> On Thu, 14 Apr 2016 11:25:47 +0000
> "Chokshi, Mitul" <mitul.chokshi at intel.com> wrote:
> > Do we really need the git commit message (subject) in version string?
> > What if we use commit hash instead? That will be a simple solution of
> > replacing %s with %H i.e. git --git-dir=$(top_srcdir)/.git log -1
> > --format='%H (%ci)'  
> I suppose we did want it, because the hash is already there, part of
> the git-describe output.

This issue surfaced again, and more people said they don't care about
the message, so I could land a patch to just remove the message and
leave revision hash as is. Or I could write it myself if you are already
tired of this.

I tried to search for a patch that already did it, but couldn't find
one on the list, so maybe it wasn't written yet.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160615/03f59045/attachment.sig>

More information about the wayland-devel mailing list