[PATCH weston 2/2] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

[Pekka Paalanen]

On Thu, 16 Jun 2016 15:34:00 +0900
Esaki Tomohito <etom at igel.co.jp> wrote:

> Hello Pekka,
> 
> Thanks for reviewing the patchset.
> 
> On 2016/06/15 17:22, Pekka Paalanen wrote:
> > On Fri, 27 May 2016 18:52:28 +0900
> > Tomohito Esaki <etom at igel.co.jp> wrote:
> >   
> >> Multiplanar formats are supported by using drmModeAddFB2 and bypassing
> >> gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path
> >> is used and multiplanar formats are unsupported.
> >>
> >> Signed-off-by: Tomohito Esaki <etom at igel.co.jp>
> >> ---
> >>  src/compositor-drm.c | 47 +++++++++++++++++++----------------------------
> >>  1 file changed, 19 insertions(+), 28 deletions(-)  
> >   
> 
> > 
> > Otherwise this patch looks good. Would you like to fix and re-post both?
> >   
> 
> Yes, I will update both patches as you suggested and send 2nd version
> soon.
> 
> > Some ideas for further development if you are interested:
> > 
> > - Check that dmabuf_attributes::flags does not contain anything we
> >   don't support in the direct scanout paths.
> > 
> > - Handle dmabuf_attributes::modifier[] when possible, or reject if
> >   non-zero.
> >   
> 
> I think that scanout will not be supported if dmabuf_attributes::flags
> contains any flag other than INTERLACED flag or
> dmabuf_attributes::modifier[] is non-zero. I can add those checks to the
> patch too.

Hi,

please make those additions as separate patches. The DRM-backend is
already ignoring to use and check these, it's not an issue that you are
introducing as completely new. It is up to you if you want to fix
existing code first and squash the similar checks in your patches, or
fix both paths at the same time as follow-up patch(es).

As for modifiers, the so-called AddFB2.1 kernel-user API supports them,
but I'm not sure it is piped through libdrm yet, so I think ensuring
modifiers are zero is fine for the moment.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160616/aea7c803/attachment.sig>