[PATCH v2 libinput 00/10] pad: add a mode toggle API

Jason Gerecke killertofu at gmail.com
Tue Jun 21 18:25:27 UTC 2016

On 06/14/2016 11:37 PM, Peter Hutterer wrote:
> Updated patchset adds EKR support and fixes a bunch of issues pointed out in
> v1. Patch 04 is intentionally missing, that's the SVG being added which
> wouldn't make it past the mailman filters.
> The branch is available on
> https://github.com/whot/libinput/tree/wip/tablet-pad-modes-v2
> One important thing of note: Benjamin and I discussed the kernel side of
> things and we'll be aiming for handling the LED toggling in the kernel
> through the LED class interface. This means that libinput won't need write
> support to sysfs and that libinput doesn't actually have to update the mode,
> merely read the changed mode.
> this also means that patch 06 and 07 will change significantly though the
> public API will remain the same. once the kernel patches are on track to be
> in an upstream kernel I'll update the implementation, for now we go with
> this one.
> Cheers,
>   Peter

Aside from the small comments on two of the patches, this looks good to
me. Testing also seems to look good aside from the not-yet-implemented
direct mode switching on my 24HD.

Reviewed-by: Jason Gerecke <jason.gerecke at wacom.com>

Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....

More information about the wayland-devel mailing list