[PATCH v2 libinput 00/10] pad: add a mode toggle API

Peter Hutterer peter.hutterer at who-t.net
Wed Jun 22 01:54:48 UTC 2016

On Tue, Jun 21, 2016 at 11:25:27AM -0700, Jason Gerecke wrote:
> On 06/14/2016 11:37 PM, Peter Hutterer wrote:
> > 
> > Updated patchset adds EKR support and fixes a bunch of issues pointed out in
> > v1. Patch 04 is intentionally missing, that's the SVG being added which
> > wouldn't make it past the mailman filters.
> > 
> > The branch is available on
> > https://github.com/whot/libinput/tree/wip/tablet-pad-modes-v2
> > 
> > One important thing of note: Benjamin and I discussed the kernel side of
> > things and we'll be aiming for handling the LED toggling in the kernel
> > through the LED class interface. This means that libinput won't need write
> > support to sysfs and that libinput doesn't actually have to update the mode,
> > merely read the changed mode.
> > 
> > this also means that patch 06 and 07 will change significantly though the
> > public API will remain the same. once the kernel patches are on track to be
> > in an upstream kernel I'll update the implementation, for now we go with
> > this one.
> > 
> > Cheers,
> >   Peter
> Aside from the small comments on two of the patches, this looks good to
> me. Testing also seems to look good aside from the not-yet-implemented
> direct mode switching on my 24HD.

I'll leave this out of this series since we're pushing this into the kernel
anyway. This branch will work well enough to get the rest of the userspace
stack in place, then when the kernel patches are in I'll switch libinput
over to use that. So you and your 24HD just have to be patient :)

> Reviewed-by: Jason Gerecke <jason.gerecke at wacom.com>

thanks, much appreciated


More information about the wayland-devel mailing list