Questions about experimental Spice compositor rebase

[Fabio Fantoni]

2016-03-03 18:57 GMT+01:00 Yury Shvedov <shved at lvk.cs.msu.su>:

> I cherry-picked your commits to my repo
> <https://github.com/ein-shved/compositor-spice/commits/spice> with some
> modifications. Take a look if you want =).
>

I saw your change, compression option I think should be image compression
or similar because is an image compression (lossless), there are also other
compression parameters I'll add (probably starting from the lossy
compression for wan).
About 2 functions (name2enum and parse_name) use for now only by image
compression will be used also by other parameters and is good to have it
out to avoid too many "duplicate code".
Take a look here for example:
http://git.qemu.org/?p=qemu.git;a=blob;f=ui/spice-core.c (qemu should have
all spice features FWIK)
https://cgit.freedesktop.org/xorg/driver/xf86-video-qxl/tree/src/spiceqxl_spice_server.c
(xspice probably don't have all spice features)
I don't mean to do same code but at least consider future add of other
features, some are fast/easy to add, other require bigger think as
prerequisite (vdagent, usbredir ecc...)



>
> On 03/03/2016 05:23 PM, Fabio Fantoni wrote:
>
> Il 03/03/2016 17:03, Yury Shvedov ha scritto:
>
>
>
> On 03/03/2016 04:40 PM, Fabio Fantoni wrote:
>
> host and port parameter are working, added also in documentation
>
> Perfect! Thank you!
>
> It is not a problem for me, I do it quickly.
>
> Ok, it is up to you.
>
> I did very fast some small commits:
> https://github.com/Fantu/compositor-spice/commits/rebase/spice-1.10
> Based on latest stable to avoid regression not related to spice.
>
> Thank you! But there are some points in image compression commit
> <https://github.com/Fantu/compositor-spice/commit/61e87fe3047acf5a4ef69f8aeafba6a8f5409a9a>
> I don't really like. For example exit(1). I will suggest some additions
> soon. Will discuss =)
>
>
> Sorry I did it in few minutes looking qemu and xspice and I not modified
> it like looking other weston things.
>
> Don't worry there are many bad places in my code need to be fixed.
>
>
> I did fast test connecting from lan computer and is working.
>
> Good to hear!
>
> You should able to cherry-pick all commits after "Add Spice compositor"
> without problem if the commits are ok for you.
>
> In the weekend probably I'll add other spice features support.
>
> I hope I'll be it time with new Spice API and warnings fixing.
>
> --
> Kind Regards,
> Yury Shvedov
>
>
>
> --
> Kind Regards,
> Yury Shvedov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160303/252e1227/attachment-0001.html>