[PATCH weston 1/3] input: Activate view no matter the keyboard focus

Daniel Stone daniel at fooishbar.org
Wed May 4 08:53:16 UTC 2016


On 15 March 2016 at 13:14, Jonas Ådahl <jadahl at gmail.com> wrote:
> Activate a view even though it effectively may already be active.
> Without this, in later patches, it won't be possibe to track what view
> was activated by clicking last, as a view which surface already had
> keyboard focus, won't be activated.
> To keep avoiding sending xdg_surface.configure events, only change the
> keyboard focus if the focus actually changed.
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> ---
> The patch that introduced the early-out if the surface already had keyboard
> focus broke activated-view tracking later used by pointer constraints. I partly
> reverted that but added a guard for changing the keyboard focus to the same
> focus, which was the reason xdg_surface.configure was sent twice per click.
> We still do various other unnecessary things on the redundant activation, but
> I left that for the future.

I'll leave this to Derek to comment, since IIRC this resulted in
spamming the active client with constant messages, which would cause
naïve clients to do re-layout etc.


More information about the wayland-devel mailing list