[PATCH weston 2/3] Implement pointer locking and confinement

Daniel Stone daniel at fooishbar.org
Wed May 4 09:00:29 UTC 2016

Hi Jonas,

On 15 March 2016 at 13:14, Jonas Ã…dahl <jadahl at gmail.com> wrote:
> This patch implements the wp_pointer_constraints protocol used for
> locking or confining a pointer. It consists of a new global object with
> two requests; one for locking the surface to a position, one for
> confining the pointer to a given region.
> In this patch, only the locking part is fully implemented as in
> specified in the protocol, while confinement is only implemented for
> when the union of the passed region and the input region of the confined
> surface is a single rectangle.
> Note that the pointer constraints protocol is still unstable and as
> such has the unstable protocol naming conventions applied.

There are really six patches in this:
  - add surface->commit_signal (Reviewed-by me)
  - change compositor->activate_signal data (R-b me)
  - add pointer->destroy_signal (R-b me)
  - split weston_pointer_send_motion from default_grab_pointer_motion (R-b me)
  - ditto weston_pointer_send_button (R-b me)
  - add pointer constraints (Acked-by me)

3/3 in the series is also Acked-by me, but I'd want someone like Derek
to at least cast an eye over 1/3 to make sure it's not going to have
too big an impact right before a stable release.

Can you please split these and merge? Sorry, I know it's annoying, but
there's enough in here that it'd be good to have both for bisect, and
people trying to follow what's happened.


More information about the wayland-devel mailing list