[PATCH weston v2] weston.pc: Properly specify Requires.private

Daniel Stone daniel at fooishbar.org
Wed May 4 09:04:27 UTC 2016


Hi,

On 6 April 2016 at 13:09, Quentin Glidic
<sardemff7+wayland at sardemff7.net> wrote:
> On 06/04/2016 08:39, Bryce Harrington wrote:
>> One thing I wonder is if any of these might need to become a Require
>> when we are providing a libweston library API?
>
> From [1] which references [2], a lot of pkg-config files are doing it wrong.
> Requires should only be used in rare cases (though it appeared quite late in
> pkg-config, and most projects just didn’t update).
> I believe the most common case is with GObject: the G_TYPE_CHECK_* macros
> are calling g_type_check_* functions which are libgobject-2.0.so symbols.
>
> In Weston, we have no such thing, so we are safe.

Yes, indeed. I went through this as both Xorg upstream and a packager,
and this all sounds right. Merged with mine & Bryce's review, thanks!

Cheers,
Daniel


More information about the wayland-devel mailing list