[PATCH weston v2 0/9] wayland-backend: refactor the configuration API

Pekka Paalanen ppaalanen at gmail.com
Wed May 4 12:46:39 UTC 2016


On Thu, 28 Apr 2016 20:33:07 +0200
Benoit Gschwind <gschwind at gnu-log.net> wrote:

> I did a patches set that split the previous patch in severals steps. The step
> intend to help the review, and may not be logical. The patch is focuced on
> keeping the legacy configuration behaviours.
> 
> Benoit Gschwind (9):
>   wayland-backend: Create a basic config structure to use in new init
>     API
>   wayland-backend: fix memory leak of display_name
>   wayland-backend: use new config struture to create backend
>   wayland-backend: move config parsing in create_cursor
>   wayland-backend: define output configuration structure
>   wayland-backend: split wayland_output_create_for_config
>   wayland-backend: split init_backend
>   wayland-backend: put configuration structure in separate header
>   wayland-backend: move all parsing functions to weston
> 
>  Makefile.am              |   3 +
>  src/compositor-wayland.c | 187 +++++++++++------------------------------
>  src/compositor-wayland.h |  63 ++++++++++++++
>  src/main.c               | 211 ++++++++++++++++++++++++++++++++++++++++++++++-
>  4 files changed, 323 insertions(+), 141 deletions(-)
>  create mode 100644 src/compositor-wayland.h
> 

Hi,

I looked through patches 1-8 and I think they are acceptable, with some
changes I did:

- Patches 5 and 6 squashed plus fixing fullscreen scale value back to
  the hardcoded 1.

- Patch 7 rebased.

- Patch 8 needed moving the #include out of the extern "C".

Patch 9 is still to review.

Push:
   d62004e..639322a  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160504/df9ed678/attachment.sig>


More information about the wayland-devel mailing list