[PATCH wayland] private: Remove unnecessary forward declarations

Derek Foreman derekf at osg.samsung.com
Mon May 9 18:24:29 UTC 2016


On 07/05/16 09:11 AM, Yong Bakos wrote:
> From: Yong Bakos <ybakos at humanoriented.com>
> 
> Declarations for wl_connection and wl_closure are not needed here.
> wl_closure already has a complete definition.
> Removing these forward declarations results in a clean, warning-free compile.
> 
> Signed-off-by: Yong Bakos <ybakos at humanoriented.com>
> ---
>  src/wayland-private.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/wayland-private.h b/src/wayland-private.h
> index 994bc45..0d8b630 100644
> --- a/src/wayland-private.h
> +++ b/src/wayland-private.h
> @@ -99,10 +99,6 @@ wl_map_lookup_flags(struct wl_map *map, uint32_t i);
>  void
>  wl_map_for_each(struct wl_map *map, wl_iterator_func_t func, void *data);
>  
> -struct wl_connection;
> -struct wl_closure;
> -struct wl_proxy;

Trying to think of a place in C where a forward struct declaration is
actually required.

This file isn't it. ;)

Reviewed-by: Derek Foreman <derekf at osg.samsung.com>

> -
>  int
>  wl_interface_equal(const struct wl_interface *iface1,
>  		   const struct wl_interface *iface2);
> 



More information about the wayland-devel mailing list