[PATCH wayland] private: Remove unnecessary forward declarations

Bryce Harrington bryce at osg.samsung.com
Wed May 11 18:12:05 UTC 2016


On Mon, May 09, 2016 at 01:24:29PM -0500, Derek Foreman wrote:
> On 07/05/16 09:11 AM, Yong Bakos wrote:
> > From: Yong Bakos <ybakos at humanoriented.com>
> > 
> > Declarations for wl_connection and wl_closure are not needed here.
> > wl_closure already has a complete definition.
> > Removing these forward declarations results in a clean, warning-free compile.
> > 
> > Signed-off-by: Yong Bakos <ybakos at humanoriented.com>
> > ---
> >  src/wayland-private.h | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/src/wayland-private.h b/src/wayland-private.h
> > index 994bc45..0d8b630 100644
> > --- a/src/wayland-private.h
> > +++ b/src/wayland-private.h
> > @@ -99,10 +99,6 @@ wl_map_lookup_flags(struct wl_map *map, uint32_t i);
> >  void
> >  wl_map_for_each(struct wl_map *map, wl_iterator_func_t func, void *data);
> >  
> > -struct wl_connection;
> > -struct wl_closure;
> > -struct wl_proxy;
> 
> Trying to think of a place in C where a forward struct declaration is
> actually required.
> 
> This file isn't it. ;)
> 
> Reviewed-by: Derek Foreman <derekf at osg.samsung.com>

Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

I've rebased it to trunk and pushed:
   385906b..f86fbe1  master -> master


> > -
> >  int
> >  wl_interface_equal(const struct wl_interface *iface1,
> >  		   const struct wl_interface *iface2);
> > 
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list