[PATCH weston] compositor-drm: Don't drop viewported surfaces into the cursor plane

[Daniel Stone]

Hi Derek,

On Friday, 30 September 2016, Derek Foreman <derekf at osg.samsung.com> wrote:
>
> +static bool
> +viewport_is_cursor_compatible(struct weston_buffer_viewport *viewport)
> +{
> +       /* While we could technically relax soem of these constraints
> +        * if we implemented cropping in cursor_bo_update, it doesn't
> +        * seem worth the effort.
> +        * It is also possible to more thoroughly test if src and dst
> +        * sizes match when widths aren't -1, but again, likely not
> +        * worth the complexity.
> +        */
> +       if (viewport->surface.width != -1)
> +               return false;
> +       if (wl_fixed_to_int(viewport->buffer.src_x) != 0)
> +               return false;
> +       if (wl_fixed_to_int(viewport->buffer.src_y) != 0)
> +               return false;
> +       if (wl_fixed_to_int(viewport->buffer.src_width) != -1)
> +               return false;
> +       if (viewport->surface.width != -1)
> +               return false;


Presumably one of these should be height, and are we not missing a
src_height check too? Also, might as well merge the buffer_scale check in
here too.

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160930/d0edf673/attachment-0001.html>