[PATCH weston v10 18/61] compositor-drm: Rename fb_plane to scanout_plane

[Pekka Paalanen]

On Tue,  4 Apr 2017 17:54:36 +0100
Daniel Stone <daniels at collabora.com> wrote:

> All planes being displayed have a framebuffer. What makes 'fb_plane'
> special is that it's being displayed as the primary plane by KMS.
> 
> Previous patchsets renamed this to 'primary_plane' to match the KMS
> terminology, namely the CRTC's base plane, which is controlled by
> drmModeSetCrtc in the legacy API, and identified by PLANE_TYPE ==
> "Primary" in the universal-plane API.
> 
> However, Weston uses 'primary_plane' internally to refer to the case
> where client content is _not_ directly displayed on a plane, but
> composited via the renderer, with the result of the compositing then
> shown.
> 
> Rename to 'scanout_plane' as our least-ambiguous name, and document it a
> bit.
> 
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> 
> Differential Revision: https://phabricator.freedesktop.org/D1415
> 
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> ---
>  libweston/compositor-drm.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
> index 659f1b59..8a31abb1 100644
> --- a/libweston/compositor-drm.c
> +++ b/libweston/compositor-drm.c
> @@ -233,7 +233,8 @@ struct drm_output {
>  	struct gbm_surface *gbm_surface;
>  	uint32_t gbm_format;
>  
> -	struct weston_plane fb_plane;
> +	/* Plane currently being directly displayed by KMS */

Hi,

how about:
/* Plane for a fullscreen direct scanout view */
or
/* Plane for a fullscreen composite bypass view */

The "currently" bothers me.

> +	struct weston_plane scanout_plane;

Otherwise:
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170410/46a19736/attachment.sig>