[PATCH weston v10 18/61] compositor-drm: Rename fb_plane to scanout_plane

Daniel Stone daniel at fooishbar.org
Mon Apr 17 19:47:58 UTC 2017


On 10 April 2017 at 13:37, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Tue,  4 Apr 2017 17:54:36 +0100
> Daniel Stone <daniels at collabora.com> wrote:
>> -     struct weston_plane fb_plane;
>> +     /* Plane currently being directly displayed by KMS */
> Hi,
> how about:
> /* Plane for a fullscreen direct scanout view */
> or
> /* Plane for a fullscreen composite bypass view */
> The "currently" bothers me.

Mm. This suggestion is good at this point in the series, but at 'Use
drm_plane for scanout plane' (26/61 in v10), scanout_plane->base is
the Weston plane for a fullscreen direct-scanout view, but
scanout_plane itself (weston_plane rather than drm_plane) contains the
plane configuration for whatever goes to the KMS primary plane (i.e.
the FB ID we would pass to drmModePageFlip). This is true when we move
to plane state, where output->scanout_plane->state_cur will be the
state for whatever's on the KMS primary plane.

Anyway, I've changed it in this patch and then it changes later, so if
you have any suggestions for what it should be when it begins to
reflect the KMS primary plane state, do shout there.


More information about the wayland-devel mailing list