[PATCH] compositor-drm: fix z-order inversion in plane assignment

Daniel Stone daniel at fooishbar.org
Tue Dec 5 13:44:37 UTC 2017

Hi Matt,

On 5 September 2017 at 15:13, Matt Hoosier <matt.hoosier at gmail.com> wrote:
> On Tue, Sep 5, 2017 at 9:00 AM, Daniel Stone <daniel at fooishbar.org> wrote:
>> It can't be correct to raise it to the cursor plane either, since both
>> cursor and overlay planes strictly stack above the scanout plane. I
>> guess this would read a lot easier with:
>> if (picked_scanout)
>>         next_plane = primary;
>> at the top of the loop.
> Okay, sure. I think that in practice, no cursor surface would ever
> have the right dimensions to get picked by prepare_overlay_view() or
> prepare_scanout_view(), but I agree with you in principle.
> Thanks for the feedback. I see that you've resubmitted the atomic
> modesetting series again. Do you feel like it's near enough landing
> that there's no use in trying to commit a copy of this fix to master?

Might as well just push it by now, which I have in fact done last night. Thanks!


More information about the wayland-devel mailing list