[PATCH weston] gl-renderer: remove unneeded cast

Daniel Stone daniel at fooishbar.org
Tue Dec 5 13:45:21 UTC 2017


Hi Emil,

On 31 July 2017 at 20:45, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> The variable num is of EGLint type.
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

Reviewed and pushed, thanks.

> Unrelated:
>
> The functions gl_renderer_query_dmabuf_* return bool as per the
> interface. At the same time:
>  - the caller does not check for it
>  - the function happily writes over the output storage on error
>
> Worth just dropping the return type, and documenting that on error
> num_formats shall return 0?

Seems reasonable enough, yeah.

Cheers,
Daniel


More information about the wayland-devel mailing list