[PATCH weston] weston-resizor: Don't add new frame callbacks every click

Daniel Stone daniel at fooishbar.org
Tue Dec 5 13:46:25 UTC 2017


Hi Derek,

On 24 March 2017 at 17:39, Derek Foreman <derekf at osg.samsung.com> wrote:
> Sorry, I forgot about this for a while.

So did everyone else, it seems.

> On 17/02/17 10:31 PM, Jonas Ã…dahl wrote:
>> Instead what we could do is probably to check the result of
>> window_lock_pointer(), if it succeeded, continue with setting
>> resizor->locked_input. Before trying to lock, check if we already have a
>> locked_input, and if so, skip locking and adding the frame callback.
>> Would also mean we need to clean up the locked_input on button-release
>> and on unlocked (though seems weston-resizer crashes when unlocked by
>> the compositor and not by itself).
>
> I'll gladly review and test such a patch.  Should I add a ticket in bugzilla
> so this bug isn't forgotten?

No idea what's going on here, but I've reviewed and pushed this patch
in the meantime.

Cheers,
Daniel


More information about the wayland-devel mailing list