[PATCH 5/5] wayland-scanner.mk: default --object-type to static

[Pekka Paalanen]

On Wed, 26 Jul 2017 14:56:21 +0100
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Unlike the core wayland library, it's recommended that one statically
> embeds the protocol within their binary.
> 

Hi,

that is true, but I'd rather leave this file alone. If people use it,
they start getting warnings, but nothing else changes for them. If we
don't hear people complaining for few releases, we might be able to
remove this file. I would like to see this file go, since none of our
projects use this AFAIK, so it's very untested, and I believe it cannot
cope with wayland-protocols' unstable/stable directory conventions.

OTOH, if this patch is applied and someone uses this file, their
exports will change unexpectedly.


Thanks,
pq

> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  wayland-scanner.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/wayland-scanner.mk b/wayland-scanner.mk
> index 0a72062..57f91f0 100644
> --- a/wayland-scanner.mk
> +++ b/wayland-scanner.mk
> @@ -1,5 +1,5 @@
>  %-protocol.c : $(wayland_protocoldir)/%.xml
> -	$(AM_V_GEN)$(wayland_scanner) code < $< > $@
> +	$(AM_V_GEN)$(wayland_scanner) --object-type=static code < $< > $@
>  
>  %-server-protocol.h : $(wayland_protocoldir)/%.xml
>  	$(AM_V_GEN)$(wayland_scanner) server-header < $< > $@

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170727/e52fea0f/attachment.sig>