[PATCH 5/5] wayland-scanner.mk: default --object-type to static
emil.l.velikov at gmail.com
Fri Jul 28 12:31:45 UTC 2017
On 27 July 2017 at 14:34, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Wed, 26 Jul 2017 14:56:21 +0100
> Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>> Unlike the core wayland library, it's recommended that one statically
>> embeds the protocol within their binary.
> that is true, but I'd rather leave this file alone. If people use it,
> they start getting warnings, but nothing else changes for them. If we
> don't hear people complaining for few releases, we might be able to
> remove this file. I would like to see this file go, since none of our
> projects use this AFAIK, so it's very untested, and I believe it cannot
> cope with wayland-protocols' unstable/stable directory conventions.
> OTOH, if this patch is applied and someone uses this file, their
> exports will change unexpectedly.
Very good points - both on the subtle breakage and on the actual
usefulness of the file.
FWIW, Mesa (and libva after I poked them a few times) don't use the file.
I won't decide on the "to be or not be", although I do have slight
inclination about removing it.
I'll purge the file with v2 and if people don't agree, that's fine.
More information about the wayland-devel