[PATCH weston v9 03/62] compositor-drm: Calculate more cursor state up front

[Emil Velikov]

On 10 March 2017 at 15:16, Daniel Stone <daniel at fooishbar.org> wrote:
> Hey Emil,
>
> On 9 March 2017 at 23:12, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 3 March 2017 at 23:05, Daniel Stone <daniels at collabora.com> wrote:
>>> -       x = (x - output->base.x) * output->base.current_scale;
>>> -       y = (y - output->base.y) * output->base.current_scale;
>>> +       x = (output->cursor_plane.x - output->base.x) *
>>> +               output->base.current_scale;
>>> +       y = (output->cursor_plane.y - output->base.y) *
>>> +               output->base.current_scale;
>>>
>>> -       if (output->cursor_plane.x != x || output->cursor_plane.y != y) {
>> As we're dropping this, won't we end up with lots of unnecessary calls
>> to drmModeMoveCursor() ?
>> Is there something which will help us ?
>
> True, it would increase the ioctl load, though the only way we'd hit
> this path is if we're repainting anyway, which would push increased
> load from MoveCursor no-ops into line noise?
>
Err, right. Thanks for the pointer - I'm rather fresh in this part of
the weston.

-Emil