[PATCH weston v12 00/40] Atomic modesetting

[Ucan, Emre (ADITG/ESB)]

Hi Daniel,

Is this the latest WIP branch to test " https://gitlab.collabora.com/daniels/weston/commits/wip/2017-10/atomic-v13" ?

In my opinion, it would easier to review/test your patches if you can separate them in multiple patch series.

For example, you can send at first up to "compositor-drm: Atomic modesetting support". Commit message states that it enables atomic API support for weston.
Other features like GBM_BO_IMPORT_FD_MODIFIER support are nice to have but not a hard requirement of atomic modesetting support.

What do you think ?

Best regards

Emre Ucan
Engineering Software Base (ADITG/ESB)

Tel. +49 5121 49 6937

> -----Original Message-----
> From: Daniel Stone [mailto:daniel at fooishbar.org]
> Sent: Donnerstag, 12. Oktober 2017 13:57
> To: Ucan, Emre (ADITG/ESB)
> Cc: wayland-devel at lists.freedesktop.org
> Subject: Re: [PATCH weston v12 00/40] Atomic modesetting
> 
> Hi Emre,
> 
> On 12 October 2017 at 10:20, Ucan, Emre (ADITG/ESB)
> <eucan at de.adit-jv.com> wrote:
> > I tested your branch " wip/2017-09/atomic-v12" on Intel Apollo Lake with:
> > - Linux Kernel v4.9
> > - Libdrm 2.4.83
> > - Mesa 13.0.6
> 
> Thanks for testing!
> 
> > In the end, I could not test the atomic modesetting with this setup. I got
> this warning "DRM: does not support atomic modesetting".
> > When I checked the source code, I saw that atomic modesetting depends
> on DRM_CAP_CRTC_IN_VBLANK_EVENT, which is introduced to the kernel
> with this commit "5db06a8a98f515f67446a69c57577c4c363ec65d" in 4.12 Linux
> kernel.
> 
> Yep; it should be quite a simple backport.
> 
> > I also saw a regression. After desktop-shell sets the display black, weston
> crashed with this callstack:
> > Oct 04 02:25:39 gr-mrb-64 weston[1922]: weston:
> ../../../../../../../../weston/libweston/compositor.c:2474:
> weston_output_finish_frame: Assertion `output->repaint_status ==
> REPAINT_AWAITING_COMPLETION' fa
> > iled.
> 
> This is already fixed. :) My current WIP branch and status is
> available here: https://phabricator.freedesktop.org/T7595
> 
> There are still some issues with DPMS, but I think we have quite a
> good workaround now.
> 
> Cheers,
> Daniel