[PATCH weston] ivi-shell: Fix incorrect use of logical instead of bitwise operator

Alexandros Frantzis alexandros.frantzis at collabora.com
Fri Nov 17 11:39:06 UTC 2017


Fix the code to use the correct bitwise AND operator '&', instead of the
currently used logical AND operator '&&', to check the value of a bit
flag in a bit mask.

This problem was reported as a warning when building with clang.
---
 ivi-shell/ivi-layout.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
index 87adde32..394179b8 100644
--- a/ivi-shell/ivi-layout.c
+++ b/ivi-shell/ivi-layout.c
@@ -617,7 +617,7 @@ commit_changes(struct ivi_layout *layout)
 			* the weston_view below this ivi_view. Otherwise content
 			* of this ivi_view will stay visible.
 			*/
-			if ((ivilayer->prop.event_mask | ivisurf->prop.event_mask) &&
+			if ((ivilayer->prop.event_mask | ivisurf->prop.event_mask) &
 			    IVI_NOTIFICATION_VISIBILITY)
 				weston_view_damage_below(ivi_view->view);
 
-- 
2.14.1



More information about the wayland-devel mailing list