[PATCH weston] ivi-shell: Fix incorrect use of logical instead of bitwise operator

[Ucan, Emre (ADITG/ESB)]

Hi,

Thank you for the patch. It looks good to me.

Reviewed-by: Emre Ucan <eucan at de.adit-jv.com>

Best regards

Emre Ucan
Engineering Software Base (ADITG/ESB)

Tel. +49 5121 49 6937

> -----Original Message-----
> From: wayland-devel [mailto:wayland-devel-
> bounces at lists.freedesktop.org] On Behalf Of Alexandros Frantzis
> Sent: Freitag, 17. November 2017 12:39
> To: wayland-devel at lists.freedesktop.org
> Subject: [PATCH weston] ivi-shell: Fix incorrect use of logical instead of
> bitwise operator
> 
> Fix the code to use the correct bitwise AND operator '&', instead of the
> currently used logical AND operator '&&', to check the value of a bit
> flag in a bit mask.
> 
> This problem was reported as a warning when building with clang.
> ---
>  ivi-shell/ivi-layout.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
> index 87adde32..394179b8 100644
> --- a/ivi-shell/ivi-layout.c
> +++ b/ivi-shell/ivi-layout.c
> @@ -617,7 +617,7 @@ commit_changes(struct ivi_layout *layout)
>  			* the weston_view below this ivi_view. Otherwise
> content
>  			* of this ivi_view will stay visible.
>  			*/
> -			if ((ivilayer->prop.event_mask | ivisurf-
> >prop.event_mask) &&
> +			if ((ivilayer->prop.event_mask | ivisurf-
> >prop.event_mask) &
>  			    IVI_NOTIFICATION_VISIBILITY)
>  				weston_view_damage_below(ivi_view-
> >view);
> 
> --
> 2.14.1
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel